Fix lexing MacroVar syntax in literal#16779
Open
straight-shoota wants to merge 3 commits intocrystal-lang:masterfrom
Open
Fix lexing MacroVar syntax in literal#16779straight-shoota wants to merge 3 commits intocrystal-lang:masterfrom
MacroVar syntax in literal#16779straight-shoota wants to merge 3 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
straight-shoota
force-pushed
the
fix/lexer-macro-delimited
branch
from
27c71a2 to
8e3527d
Compare
straight-shoota
force-pushed
the
fix/lexer-macro-delimited
branch
from
8e3527d to
04ece9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour documented in #16778: We should never parse a
MacroVarinside a literal.This patch includes a refactor that simplifies lexing precent literal delimiters significantly with a generalized helper method
delimiter_state_for_percent_literal.Unfortunately, the refactor and bugfix are deeply intertwined and mutually depend on each other. Merging either individually breaks some expectations. So I figure it's easier to commit them as a single change.
Still, the first two commits are refactors, the last one is the actual bug fix.
The significant change is standardized detection and parsing of percent literal delimiters, and the actual parsing for macro tokens happens in a single place. By being able to clearly identify these delimiters, we can strictly separate them from
MacroVarsyntax.Depends on #16778